bsglz
bsglz
Please fix the checkstyle issue, and there are some duplicated code, can we extract them into a method? Thanks.
> Mind explaining more about your solution? Yeah, the problem here is we put too many compactions to queue, so i think the solution for it is to find how...
> The idea looks good overall. @bsglz do you have any recommendation on the max files to compact value? Do you mean the value for hbase.hstore.compaction.max? The default value is...
> +1 overall, also the idea seems good. @bsglz let's wait for one more review? No prob, thanks a lot.
@Apache9 Can i have +1 from you, or any more issues? Thanks a lot.
The failure test passed in local, seems not related to this pr, trigger it again.
> `hbase-default.xml` changes are included by mistake? Oh, yeah, sorry.
> We have this condition: > > ``` > private static boolean isValidHour(int hour) { > return 0 ``` > > which means 0 and 23 are inclusive only right?...
The related logic shows below. > @Override > public boolean isOffPeakHour(int targetHour) { > if (startHour return startHour } > return targetHour < endHour || startHour } this line: return...