hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-26017 fix pe tool totalRows exceed maximum of int

Open dingwei-2017 opened this issue 4 years ago • 17 comments

fix pe tool totalRows exceed maximum of int. when totalRows exceed maximum of int, we throws RunTimeException. already create https://issues.apache.org/jira/browse/HBASE-26017

dingwei-2017 avatar Jun 24 '21 07:06 dingwei-2017

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 1s master passed
+1 :green_heart: compile 0m 27s master passed
+1 :green_heart: shadedjars 8m 12s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 21s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 43s the patch passed
+1 :green_heart: compile 0m 26s the patch passed
+1 :green_heart: javac 0m 26s the patch passed
+1 :green_heart: shadedjars 8m 14s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 18s the patch passed
_ Other Tests _
+1 :green_heart: unit 11m 10s hbase-mapreduce in the patch passed.
38m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux d0929f7cd185 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dcd0fb8b1d
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/testReport/
Max. process+thread count 3636 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 24 '21 08:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 6s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 0s master passed
+1 :green_heart: compile 0m 29s master passed
+1 :green_heart: shadedjars 9m 7s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 22s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 50s the patch passed
+1 :green_heart: compile 0m 29s the patch passed
+1 :green_heart: javac 0m 29s the patch passed
+1 :green_heart: shadedjars 8m 57s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 21s the patch passed
_ Other Tests _
+1 :green_heart: unit 14m 46s hbase-mapreduce in the patch passed.
46m 42s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux a9c6f30cb31e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dcd0fb8b1d
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/testReport/
Max. process+thread count 3481 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 24 '21 08:06 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 15s master passed
+1 :green_heart: compile 1m 1s master passed
+1 :green_heart: checkstyle 0m 24s master passed
+1 :green_heart: spotbugs 0m 53s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 50s the patch passed
+1 :green_heart: compile 0m 56s the patch passed
+1 :green_heart: javac 0m 56s the patch passed
-0 :warning: checkstyle 0m 21s hbase-mapreduce: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)
-0 :warning: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 :warning: whitespace 0m 0s The patch 1 line(s) with tabs.
+1 :green_heart: hadoopcheck 23m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 :green_heart: spotbugs 1m 14s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
49m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux c1dbd4336459 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dcd0fb8b1d
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-general-check/output/whitespace-tabs.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jun 24 '21 08:06 Apache-HBase

@busbey thanks

dingwei-2017 avatar Jun 25 '21 03:06 dingwei-2017

‘larger than’ -> 'greater than'

And mind explain a bit on how do you test whether totalRows exceeds maximum of int?

Thanks.

Apache9 avatar Jun 28 '21 04:06 Apache9

@Apache9 sure. when i run the following command: bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --size=2048 --nomapred --table=TestTable --presplit=100 sequentialWrite 100

the terminal shows the following message: 2021-06-23 06:52:17,654 INFO [TestClient-9] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -193273524 for -21474836 rows 2021-06-23 06:52:17,654 INFO [TestClient-8] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -171798688 for -21474836 rows 2021-06-23 06:52:17,654 INFO [TestClient-13] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -279172868 for -21474836 rows 2021-06-23 06:52:17,654 INFO [TestClient-10] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -214748360 for -21474836 rows 2021-06-23 06:52:17,654 INFO [TestClient-5] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -107374180 for -21474836 rows 2021-06-23 06:52:17,655 INFO [TestClient-14] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -300647704 for -21474836 rows 2021-06-23 06:52:17,654 INFO [TestClient-1] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -21474836 for -21474836 rows

This is because opts.totalRows exceeds the max value of Int. rowsPerGB is 1024 * 1024 by default, when opts.size is larger than 2048, opts.size * rowPerGB is larger than 2147483648. the code is in calculateRowsAndSize api.

dingwei-2017 avatar Jun 30 '21 04:06 dingwei-2017

Please add some comments in the code?

Thanks.

Apache9 avatar Jul 02 '21 06:07 Apache9

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 28s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 48s master passed
+1 :green_heart: compile 0m 28s master passed
+1 :green_heart: shadedjars 8m 15s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 18s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 47s the patch passed
+1 :green_heart: compile 0m 25s the patch passed
+1 :green_heart: javac 0m 25s the patch passed
+1 :green_heart: shadedjars 8m 5s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 18s the patch passed
_ Other Tests _
+1 :green_heart: unit 12m 0s hbase-mapreduce in the patch passed.
39m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux 29876f0cf4de 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97fbfc
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/testReport/
Max. process+thread count 3592 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 06 '21 09:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 32s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 42s master passed
+1 :green_heart: compile 0m 30s master passed
+1 :green_heart: shadedjars 8m 19s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 23s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 46s the patch passed
+1 :green_heart: compile 0m 31s the patch passed
+1 :green_heart: javac 0m 31s the patch passed
+1 :green_heart: shadedjars 8m 35s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 21s the patch passed
_ Other Tests _
+1 :green_heart: unit 10m 35s hbase-mapreduce in the patch passed.
40m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux 09f15720512e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97fbfc
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/testReport/
Max. process+thread count 4758 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 06 '21 09:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 53s master passed
+1 :green_heart: compile 0m 56s master passed
+1 :green_heart: checkstyle 0m 22s master passed
+1 :green_heart: spotbugs 0m 58s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 33s the patch passed
+1 :green_heart: compile 0m 54s the patch passed
+1 :green_heart: javac 0m 54s the patch passed
-0 :warning: checkstyle 0m 20s hbase-mapreduce: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)
-0 :warning: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 :warning: whitespace 0m 1s The patch 1 line(s) with tabs.
+1 :green_heart: hadoopcheck 23m 57s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 :green_heart: spotbugs 1m 8s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 12s The patch does not generate ASF License warnings.
48m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 08162842249f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97fbfc
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/artifact/yetus-general-check/output/whitespace-tabs.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 06 '21 10:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 31s Docker mode activated.
-0 :warning: yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 10s master passed
+1 :green_heart: compile 0m 29s master passed
+1 :green_heart: shadedjars 8m 43s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 21s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 57s the patch passed
+1 :green_heart: compile 0m 28s the patch passed
+1 :green_heart: javac 0m 28s the patch passed
+1 :green_heart: shadedjars 7m 59s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 19s the patch passed
_ Other Tests _
+1 :green_heart: unit 10m 41s hbase-mapreduce in the patch passed.
38m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux c064829c6f55 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97fbfc
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/testReport/
Max. process+thread count 4526 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 06 '21 10:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 58s master passed
+1 :green_heart: compile 0m 58s master passed
+1 :green_heart: checkstyle 0m 23s master passed
+1 :green_heart: spotbugs 0m 55s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 52s the patch passed
+1 :green_heart: compile 1m 0s the patch passed
+1 :green_heart: javac 1m 0s the patch passed
-0 :warning: checkstyle 0m 22s hbase-mapreduce: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 23m 46s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 :green_heart: spotbugs 1m 7s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 13s The patch does not generate ASF License warnings.
49m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux c597633beb3b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97fbfc
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 06 '21 10:07 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 9s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 3s master passed
+1 :green_heart: compile 0m 37s master passed
+1 :green_heart: shadedjars 11m 6s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 30s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 6m 5s the patch passed
+1 :green_heart: compile 0m 35s the patch passed
+1 :green_heart: javac 0m 35s the patch passed
+1 :green_heart: shadedjars 10m 29s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 24s the patch passed
_ Other Tests _
+1 :green_heart: unit 17m 51s hbase-mapreduce in the patch passed.
55m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux ff631817ae2a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a3ad97fbfc
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/testReport/
Max. process+thread count 3306 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jul 06 '21 11:07 Apache-HBase

Please fix the checkstyle issue, and there are some duplicated code, can we extract them into a method? Thanks.

bsglz avatar Jul 07 '21 07:07 bsglz

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 14s master passed
+1 :green_heart: compile 0m 50s master passed
+1 :green_heart: checkstyle 0m 22s master passed
+1 :green_heart: spotbugs 0m 47s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 53s the patch passed
+1 :green_heart: compile 0m 47s the patch passed
+1 :green_heart: javac 0m 47s the patch passed
-0 :warning: checkstyle 0m 21s hbase-mapreduce: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 19m 32s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 :green_heart: spotbugs 0m 56s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 15s The patch does not generate ASF License warnings.
40m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux b9a97a15593f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f6348d4100
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 27 '22 22:01 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 2m 22s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 22s master passed
+1 :green_heart: compile 0m 31s master passed
+1 :green_heart: shadedjars 10m 20s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 26s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 45s the patch passed
+1 :green_heart: compile 0m 32s the patch passed
+1 :green_heart: javac 0m 32s the patch passed
+1 :green_heart: shadedjars 10m 22s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 22s the patch passed
_ Other Tests _
+1 :green_heart: unit 14m 3s hbase-mapreduce in the patch passed.
50m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux f3a56eff4f2c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f6348d4100
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/testReport/
Max. process+thread count 3511 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 27 '22 22:01 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 4s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 5m 56s master passed
+1 :green_heart: compile 0m 34s master passed
+1 :green_heart: shadedjars 10m 26s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 26s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 6m 5s the patch passed
+1 :green_heart: compile 0m 31s the patch passed
+1 :green_heart: javac 0m 31s the patch passed
+1 :green_heart: shadedjars 9m 19s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 21s the patch passed
_ Other Tests _
+1 :green_heart: unit 15m 1s hbase-mapreduce in the patch passed.
50m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/3423
Optional Tests javac javadoc unit shadedjars compile
uname Linux c83634675a46 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f6348d4100
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/testReport/
Max. process+thread count 3313 (vs. ulimit of 30000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3423/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Jan 27 '22 22:01 Apache-HBase