Ben Sedat

Results 16 comments of Ben Sedat

As a note for anyone else, an equivalent patch can also be made to the File provider to allow it to supersede env var bindings when an overridden attribute is...

When do you think a new version of this gem will be cut/released with this fix?

> @bsedat @QuinnWilton I believe we can remove the base64 encoded hack for windows, since we're no longer going to be passing the args through any of the batch files,...

I wonder if we should have apps set `include_erts: false` and `include_executables_for: []` in their mix release?

I think we'll also need to pass along the `-config` arg to erlang. I'm still looking for where the runtime config provider receives the temporary config file to give to...

> I think we'll also need to pass along the `-config` arg to erlang. I'm still looking for where the runtime config provider receives the temporary config file to give...

> > > I think we'll also need to pass along the `-config` arg to erlang. I'm still looking for where the runtime config provider receives the temporary config file...

Tried it with Windows and it seems to be working, so just have a final question around the arguments and then I'd be ready to merge!

Just to check, do you have a `rel/env.bat.eex`, `rel/env.sh.eex` which set `RELEASE_DISTRIBUTION=none`? The bat file should have `set RELEASE_DISTRIBUTION=none` and the sh file should have `export RELEASE_DISTRIBUTION=none`.

Same result with the official Elixir image, which is also missing that file in the bin directory. ASDF-installed Elixir seems to be alright though, so I'm exploring that as a...