Bruno Schaatsbergen

Results 163 comments of Bruno Schaatsbergen

Do what fits you and think is best and easiest to maintain on long term. Incase the whole section is outdated, replace it or just re-format it properly. Thanks for...

I was facing the same issue: _Response: {'ok': False, 'error': 'missing_scope', 'needed': 'chat:write:bot', 'provided': 'incoming-webhook,calls:write'}_ After some digging on community forums, It seems like _"chat:write:bot"_ is not accessible from the...

> Any updates on this? It's WIP at the moment. I'm trying to get it done in the coming few days.

Hi @scottwestover, thanks for taking the time to raise this PR. Please note that as per the docs [here](https://docs.aws.amazon.com/waf/latest/developerguide/waf-rule-statement-oversize-handling.html), Oversize Handling applies to more places in the WAFv2 Webl ACL;...

> @bschaatsbergen Yes, it does apply to the other `FieldToMatch` types, however most of those types do not appear to be supported currently in the provider: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/wafv2_web_acl#field-to-match. > > My...

Hi @scottwestover, great work. I've addressed it with one of the core team members and they will take a look at this.

I'm going to wait for some feedback on this PR, whether it fits the roadmap, etc. before finalizing this.

> @bschaatsbergen I don't know how long you are planning on waiting, but you might want to set the PR to 'Ready for review' to get it reviewed by one...

@melinath, I would like to pick this up but we should first agree on the implementation. As you've stated - it seems like this doesn't directly map to an API...

@gdavison, looking at https://github.com/hashicorp/terraform-provider-aws/commit/226cd4f55e572f733d8790484d8d79ba72c4ba92, was there any specific reason to remove this?