Brynn Zalmanek
Brynn Zalmanek
@turbomam I added the names of the migrators. I am thinking the `migrator_from_X_to_PR10` should go at the bottom of the list. It does not really matter now, but when we...
@anastasiyaprymolenna when you are finished with writing the migrator that removes the `used` slot from `WorkflowExecution` can you edit the big comment above to add that migrator in the correct...
We are done writing the migrators. I think we can probably close this issue, unless @eecavanna wants to keep it open for the rest of the implementation steps? But I...
After discussion with @kheal and @anastasiyaprymolenna `has_calibration` is fine the way its modeled on `ChromatographicSeparationProcess`. Calibration does not need to have its own class. There are no calibration reagents to...
@kheal after thinking about this further, I don't think we should add the `has_calibration` in the change sheet and write a migrator to remove the slot from the `WorkflowExecution`. This...
See list of migration scripts in progress: https://github.com/microbiomedata/nmdc-schema/issues/1607
After talking with @aclum this issue needs to be completed https://github.com/microbiomedata/nmdc-schema/issues/1617 (allowing omprc typcodes on subclasses of DataGeneration) so that this migration: https://github.com/microbiomedata/berkeley-schema-fy24/pull/29 (move has_calibration to MassSpectrometry) can happen.
@aclum I am looking into this now for the migration for this. Will the data object ids that are values for `has_calibration` be changed as part of the re-iding effort?...
@SamuelPurvine I see. Should those emsl:output_identifier have `DataObject` metadata in NMDC since `has_calibration` points to an nmdc `DataObject`. @corilo? Or is okay to just be a string that is emsl:output_identifier?...
Tagging @anastasiyaprymolenna @kheal as we are working on updating MassSpec metadata.