Johannes
Johannes
This introduces several changes as part of #37. - We put a disclaimer at the beginning of the list of known implementations. This way, it's clear that this list does...
The README refers to a non-existing License file. This should probably be added.
The API key that was previously being kindly donated by a user, is no longer valid. Thus, test-calls that rely on this fail. I don't use this part of the...
In extension to #29, perhaps it would be beneficial to add a method to the builder, that didn't require a key to be passed, but generated it randomly instead. What...
The `ttl` field of the `Branca` struct is never used. Instead, `decode()` takes a separate TTL. Maybe the `ttl` field should be removed?
`key()`, `nonce()`, `ttl()` and `timestamp()` all consume `self`. This means the builders instance needs to be cloned if a user wants to continue using it after calling any of the...
So encode could take `AsRef` instead of `&[u8]`. Originally suggested by @J-F-Liu in https://github.com/return/branca/issues/10#issuecomment-727861486
The `Hasher` enum for BLAKE2b does not derive any of the common traits found elsewhere for public items. It should at the very least implement `Debug` and probably also `PartialEq`.
The following changes in performance of ChaCha20 and related functions have been observed: `rustc 1.41.0 (5e1a79984 2020-01-27)`, `orion 0.15.0`: - ChaCha20Poly1305: Input 128KiB, Throughput 419.22 MiB/s - XChaCha20Poly1305: Input 128KiB,...