Results 46 comments of Bryan Haakman

@BitPhinix could you explain a little how the `shouldFlushPendingChanges` method works, when it should be implemented, when it should not be implemented and how it should be modified to make...

@aboveyunhai slate was redesigned at some point so that the `slate` package is just for modifying the document and `slate-react` is for the react specific part (rendering the changes to...

@mlajtos use `editor.apply` instead

@jasonphillips you're using the `use-sync-external-store` approach here to resolve the problem that React currently has with not having a way to avoid unnecessary context-triggered re-renders right? So once that becomes...

@horacioh > Should we have a testing setup for each package or just one for the whole repo? Some might be shared, others have their own testing strategy (like `slate`...

Nice work here, some questions/comments: * From what I understand, these are run more like a unit test right? So keydown events and stuff are emulated? * If we go...

@horacioh :wave: I very much agree that we need a better testing setup for slate-react as small changes can have big consequences especially due to the subtly different ways different...

@nemanja-tosic some good points there. > I don't really like using both mocha and jest like it is now, and this PR adds more jest code. I think one test...

@horacioh > we are exploring using slate-test-utils for some very specific plugin behavior (compare function(input) equals to output stuff). We have a very specific tree structure and comparing the editor...

@horacioh very nice, I assume the tests run quicker cause there's no need to start up the examples server and visit that page?