Bryan Garza

Results 59 comments of Bryan Garza

Thanks, yeah I wasn’t sure if it was still a change we wanted. Sounds good!

Since this is going to start introducing compile errors, I set the `tracing-attributes 0.2` milestone. We'll also need to fix the merge conflicts at some point.

We could probably still re-base and get this merged fyi @k-nasa

@Michael-F-Bryan - should we close this PR? Or is it something that you still would like to merge?

AFAICT we could still merge this, after a rebase and review

(Going through all open PRs) Seems this PR is pretty close to getting merged, added myself as reviewer for now, will try to look at it later today or tomorrow.

@pjankiewicz seems the CI has some failures, could you resolve those? After that we can probably merge

And I think there might be some merge conflicts too

If we rebase (and address my one comment), this could be merged