Bernhard Rusch

Results 231 comments of Bernhard Rusch

@kingjia90 I think `form` can be made optional, by using a `class_exists()` in `ContentTemplateListener`

@dpfaffenbauer not entirely through yet, but like the general idea 😍

@dpfaffenbauer through the code changes πŸ˜‰just had a quick look yet, not in detail.

@dpfaffenbauer unfortunately not yet 😬 was debugging some other tricky bugs πŸ˜‰

@dpfaffenbauer Maybe this #16545 also needs to be considered - Thanks again! 😊

@dpfaffenbauer cool, thanks a lot! One more thing, you've added unit tests for object bricks but not for relations in general and in the context of localized fields. Would be...

@dpfaffenbauer Unfortunately we have currently some other priorities, that's why we haven't found the time yet to add tests and we won't merge this PR without tests as it's quite...

@dbu were you using the config in the context of a `.htaccess` or directly in the vhost?

@dbu Yeah, I guess that's the reason then 😊 I'm not (entirely) sure whether your change also works in the context of `.htaccess` and I currently don't have the possibility...

Keeping it as it as for now for 2 reasons: - the documentation is explicitly talking about `.htaccess` context and not about others (server config, vhost, directory) - Symfony is...