Bernhard Rusch
Bernhard Rusch
I think this would be fine as it won't break anything. If you create a PR you should also consider the password generator 😊 Thanks in advance
Have you tried it using our official Docker images? https://github.com/pimcore/docker?tab=readme-ov-file#pimcore-php-docker-image EPS support depends on your ImageMagick installation, you can check it e.g. by `phpinfo()`.
Please check if this still remains an issue in latest v2 Docker images (`php8.2-latest`). There we have `ImageMagick 7.1.0-4 Q16 x86_64 2021-07-18`. If it's still an issue we need to...
Would be time then for https://github.com/marketplace/actions/prettier-action 😊
@BlackbitDevs thanks for sharing your thoughts. We had already similar discussions internally, but we haven't come to a conclusion yet how we want to deal with filters in the future....
@scrummer thanks for the hint! 👍
@kingjia90 nice idea, but I'm afraid that `isFrontendRequestByAdmin()` would throw an exception in CLI, because of https://github.com/pimcore/pimcore/blob/b6b7ed75190b9825d248dadb47d5516968669dfe/lib/Http/RequestHelper.php#L47 I'm fine with the `..$args` approach, but - [x] we should avoid duplicate...
@bitbirddev I guess `ImageThumbnailTrait` would be a good place for it, right? It's used by all afftected methods.
Looks good to me, maybe just 2 things: - I'd go for either `renderControllerActions` or `includeTemplates` but not both, I'd prefer `includeTemplates` - I'd move the include part in `login.html.twig`...
LGTM, thanks!