Bruno Blank
Bruno Blank
> There's a lot to take in and I may not get a chance to give it a good look until the weekend, though I'll try and have a look...
Thanks @alex-training for good comments. I have updated PR. The `AsyncInterceptorBase` and `CompletedInvocation` still needs work through as I was focusing on the review comments.
I did a small comparison benchmark comparing `MethodInfo.Invoke` and `Create.Delegate` ``` Method | Mean | Error | StdDev | ------------------------- |-------------:|-----------:|-----------:| Baseline | 3.691 ns | 0.0704 ns | 0.0588...
Nice, I understand the intent of the `WhenExceptionInterceptingAnAsynchronousMethodThatThrowsASynchronousException` test. Thanks for clarifying. I am still a bit confused about the `CompletedInvocation` in `ProcessingAsyncInterceptor`. Where the with returnValue is calling the...
Hi @JSkimming, how are things looking at your end?
@JSkimming I have spent some time looking at this feature again. While troubleshooting the problem in core and understand more of what the problem was. I think this PR solves...
When using the Castle.Core - IInterceptor for synchronous operations is straight forward and works very well. So having the IAsyncInterceptor _align_ with Castle.Core being asynchronous would look like this _note:...
Good breakdown @stakx! Personally I really dislike partial classes from external libraries and would prefer an interface. Having the `object Result` as a property has some pros and cons. The...
> There's no such thing as a "partial class from external libraries". partial only means that you can split a class across several source code files, and that these separate...
> Are you talking of present-day IAsyncInterceptor, or AsyncInterceptor from my post? If the latter, I'm not sure I understand. Two methods (one for sync, one for async) are a...