Bruno Pimentel
Bruno Pimentel
> I'm stuck on the part about fixing the broken unit tests. > >  > > I started trying to fix the test: `tests/test_api_v1.py::test_create_and_fetch_request`, > > I got...
I personally don't see much value into separating each fix for the unit tests into a single commit. I'd squash all FIX commits here. But that's me, let's see what...
> Seems reasonable +1 > > Are there any tests for these metrics that could be updated? If we have none, that's probably OK I don't think there are any...
Overall, LGTM. Only fix needed is adding type annotations, as mentioned.