Brian Anderson
Brian Anderson
Several file-system modifying commands in this script are not checked for errors. See for example the [symlink](https://github.com/thomie/haskell-platform/blob/4af0a6c880e24e8967f46782f70e12edb243066c/hptool/os-extras/posix/bin/activate-hs#L107) functions. It looks to me like, if these fail, the script will simply...
We are in the process of migrating to the sui codebase. There are likely new native function calls on sui that we do not implement, either in `std` or in...
We think the Sui storage model will be easier to implement on Solana than the mainline Move storage model. Let's attempt to rebase onto their tree. @jcivlin Do you want...
The stdlib test suite has solana-specific comments like ``` // TODO enable specific failure //#[expected_failure(vector_error, minor_status = 1, location = Self)] #[expected_failure] ``` where we are failing as expected but...
The `sui-move` branch (cc https://github.com/solana-labs/move/issues/396) contains these two tests, both of which fail on rbpf: ```move #[test] fun size_limit_ok() { let v = V::empty(); let i = 0; // Limit...
We pass the normal stdlib tests on rbpf. The stdlib also contains a "nursery" that is a separate project, and for which the tests fail to run at all. ```...
There are a huge number of unsafe functions in move-native, and some safe functions that probably aren't really. Reducing the number of unsafe methods would help future maintenance and potential...
From our GlobalContext we create a raw LLVM module (global_cx.llvm_cx.create_module), then pass a reference to that module into various other contexts. From comments in the code: ``` // FIXME: this...
Followup to https://github.com/solana-labs/move/issues/333 The move VM produces errors in some cases when asked to recurse deeply. move-native has no limits and will just crash if it hits the end of...
rbpf does not allow symbol names greater than 64 bytes, and in https://github.com/solana-labs/move/issues/303 I have needed to generate symbol names larger than that. rustc generates huge symbol names but they...