Ferran Brosa Planella

Results 63 comments of Ferran Brosa Planella

You need to incorporate the extra terms in `base_thermal.py` (in `_get_standard_coupled_variables` l90). You basically need to define the extra terms, which correspond to equations (20)-(21) of the [published version](https://www.sciencedirect.com/science/article/abs/pii/S0013468621011993) (let...

If the SPM error is from CasADI dimension mismatch, it is due to the averaging. If you set the average to false it should work fine (that's what I did...

Following our experience with the `coord_sys`, I think we should keep some checks somewhere in the battery submodels. But certainly not in the `BaseSubmodel` class.

Nothing in particular. Then, it might be easier to include the plating to the default parameters so, at least, if people run the default model, won't get the error.

Then this would be a very good first issue. @sklein-ise let us know if you want to give it a go as well.

Another picky general comment about the plots. The aspect ratio of the plots look a bit strange (e.g. the ones with 2 columns and 1 row are a bit too...

Looks great, thanks! Are there any changes you need to do or shall I merge?

I believe it is because for Markdown files it is recommended to use `-` instead of `_`. Maybe try renaming `release_work_precision_sets.md` to `release-work-precision-sets.md` and see if it works.

> Good idea, do you know how to do this? Not sure haha. To calculate the right stoichiometry, it should be enough to call `ElectrodeSoH` with the averaged concentrations in...

I have been thinking a bit more on the implementation and I think this is the best syntax: ``` "On day 0 at 08:00:00 discharge at 1C until 2.5 V",...