brody-qq

Results 5 comments of brody-qq

Thanks for looking over my PR. This isn't part of a bigger project, it's just something I spotted while getting myself up to speed on the filesystem code. It saves...

Sorry for taking a while, I've been pretty busy the last few weeks. I put the test case into a separate PR: #24912 Also I made the changes @timschumi suggested,...

A lot of my testing was done by running the following 2 programs in userspace and checking the debug logs for anything unusual: * https://github.com/brody-qq/serenity/blob/debug-mmap-dirty-pages/Userland/Utilities/test_mmap_dirty_pages.cpp * https://github.com/brody-qq/serenity/blob/debug-mmap-dirty-pages/Userland/Utilities/test_mmap_dirty_pages_parallel.cpp If anyone has...

I updated this to remove a FIXME comment that is fixed by this PR ``` --- a/Kernel/Memory/Region.cpp +++ b/Kernel/Memory/Region.cpp @@ -56,10 +56,8 @@ Region::Region(VirtualRange const& range, NonnullLockRefPtr vmobject, Region::~Region() {...

> Seems like one of the other kernel PRs created some conflicts Fixed, it was some new code in `Region.cpp` that didn't impact any functionality of this PR.