Brodie Gaslam

Results 74 comments of Brodie Gaslam

Probably because windows is utf-16/ucs2...

Right now `vetr` bails out as soon as it determines that an object cannot possibly meet the vetting token, which in the case of `&&` combinations is possibly as early...

Sure, I'll have a look when I have time (might be a while), but road should go both ways, right?

Currently we time the entire `unitizer` execution. Adding the timing wouldn't be too difficult, though it does require messing with the items, which means a slightly annoying upgrade process. We...

Right now we're returning a `data.frame`; perhaps should be a unitizer with a show method that produces the `data.frame`? I think part of the challenge here is that meta data...

Not sure this is worth it. Many of the tests have diffobj output embedded in them, so we would have to redo all of them in order to be able...

More generally, some way of testing graphical output.

See `ggplot2::transform_position`, which seems to be used by at least `PositionJitter` for this purpose.

Also, comparing stdout could potentially slow down test comparison, so we would have to think about this carefully