brockelmore

Results 35 comments of brockelmore

@onbjerg what if we add an inspector (or use existing inspector) and cheatcode and forge-std that: 1. records selfdestructed addresses (in the selfdestruct callback) 2. `vm.destructed(addr) -> bool` returns if...

Yep i intuitively understood that abi == trait effectively. However, it feels weird to me to impl a trait on an unspecified type (i.e. is `impl abi MyAbi` feels more...

`Self` makes more sense (`This` isn't used in rust so would shy away from that). I think this may be ideal: ```rust abi Wallet { // snip } // effectively...

Chris from the lang team seems to insist that it is devtool responsibility and that the compiler will not be adding it

i mean there is the simple version and the complex version. the simple version is very dumb and basically is: changed & imported elsewhere? rebuild all contracts that depend on...

Seems like this may be a fix for [here](https://github.com/paritytech/ethabi/blob/a985fb9f8c38bc7953f83500c92a0eda62b52f08/ethabi/src/tuple_param.rs#L77): ``` let kind = kind.ok_or_else(|| Error::missing_field("kind")).and_then(|param_type| match param_type { ParamType::Tuple(_) => { let tuple_params = components.ok_or_else(|| Error::missing_field("components"))?; Ok(ParamType::Tuple(tuple_params.into_iter().map(|param| param.kind).map(Box::new).collect())) } ParamType::Array(inner_param_type)...

here is an abi that can be used to test parsing: ``` { "constant": false, "inputs": [ { "components": [ { "components": [ { "components": [ { "name": "makerAddress", "type":...

Using the fix above, I still run into issues around the ethabi::encode; it produces much longer data than expected compared to web3.js encoding. I imagine this is around dynamic determination....

Can you concretely describe why roll and warp don't suffice?