Brian Krygsman

Results 12 comments of Brian Krygsman

Good question :) In short its because I habitually lean towards explicitness in configuration, and leverage templated configs across environments. For a bit more detail on our specific scenario: We...

I see what you mean, and you're right, its definitely worth testing in browsers, even if just to see what those requests looks like. If browsers are dropping the port...

I wondered about that... we could maybe check if `options` has a protocol set, and compare there. I pulled that logic out to separate function in case you wanted to...

Was thinking about this again last night, and this may summarize my thoughts more succinctly: _The goal of this PR is to normalize requests prior to signing them such that...

My understanding was that there was a `protocol` option available for the low-level request. I'll check how that behaves for each module. https://nodejs.org/api/http.html#http_http_request_options_callback and https://nodejs.org/api/https.html#https_https_request_options_callback

I was able to keep working a bit and explored Node HTTP module behavior. Details are recorded in this gist: https://gist.github.com/brnkrygs/a96869ee9b02ab8916c933e09a8a8381 From my (admittedly limited) testing, it looks like the...

Played with this some more... looks like if I create a python venv and install against `requirements.txt`, I can get CDK to `synth`/`deploy`: ```bash cd ../.. python3 -m venv .venv...

Additional work coming by Mohite, Sangram and Mishra, Pranshu

TypeScript changes look good. Though, I'm a bit thrown because from what I can see, `main` already has fixed links for that sample: https://github.com/aws-samples/serverless-test-samples/blob/main/typescript-test-samples/apigw-lambda-dynamodb/metadata.json