Christopher Britz

Results 10 comments of Christopher Britz

@mcollina is how i reuse splitter as a stream but instead use index api, as to demonstrate how i implemented it in this lib. Ill see what i can do...

@gustvao What do you think is broken with the scroll? I was planning on looking at it, as I like the idea of not adding jquery dependency within my AngularJS...

@gustvao Ok got fade in working, how do you want to do PR? I was thinking forking your repo, making new branch, submit PR, then you can merge it in...

@booleanbetrayal what conflicts still exist?

@gustvao I just did a PR to your master branch. I think you should pull that in and update this pr, as I did some work for fading in the...

@gustvao yeah, i just tried to merge it myself, and there are some changes that require knowledge of the directives since your fork was done pretty long ago. I almost...

@gustvao I started what i suggested above. I made a new fork then started bringing over our changes. Im working on the branch `no-jquery-manual-merge` (found here https://github.com/BritzTownRiots/angular-tour/tree/no-jquery-manual-merge). I basically have...

@kisonay thats fine. Id rather you look at it then myself, since implemented it. Plus I am going to have some fun with these callbacks.

@gustvao how do you fork into a new branch. Your master branch is already ahead/behind @booleanbetrayal master, so pulling the upstream master into your master branch will end in the...