Brian Riley

Results 113 comments of Brian Riley

I'm unsure what the issue is about. The JSON is just the common standard format and so doesn't include the narrative. Is this a request to add the narrative to...

Ok. Perhaps there's a way to add it to both but we'll need to discuss. We just had a PR to DMPTool to allow the templates from our API v2...

Just discovered today that Rails is [no longer supporting the Webpacker gem](https://github.com/rails/webpacker). I learned this after running `yarn upgrade` and noticing that all of the Karma tests would no longer...

Hi @benjaminfaure I think that's probably the best course of action. Just create a rails_6 branch off of the development branch and push it up to this repository. We can...

Thanks for getting this started @benjaminfaure and for creating the [rails_6 branch](https://github.com/DMPRoadmap/roadmap/tree/rails_6). We can all begin to work from there (or branched that stem from rails_6). I was able to...

Added a new wiki page to record upgrade notes: https://github.com/DMPRoadmap/roadmap/wiki/Rails-Upgrade-Notes The intended audience would be developers who manage their own instances and may need to upgrade their own cutomizations

I was just doing some reading on Rails 7 and discovered that they're moving away from Webpacker and UJS (which they introduced in Rails 5/6). An apparent side effect is...

Thanks @pengyin-shan! I find it super frustrating that they would not make something like that backwards compatible since they introduced it and guided us all to adopt it :/

Agreed, the boundaries between the two have always been a bit strange and hard to manage. There doesn't appear to any official guidance at this point. for example: https://stackoverflow.com/questions/71422105/rails-ajax-rails-is-not-defined-rails-7 This...

@raycarrick-ed filled me in on this one. This would work for the ROR implementation we have and it would be desirable.