Results 64 comments of Brian Maher

This seems to have languished, so I put together this proposal: https://github.com/apple/swift-log/pull/316 If I get the thumbs up, then I'll put together a PR with that implementation. Please provide feedback...

Patches are always welcomed :). Thanks, -Brian

@hishamhm what do you think of dropping support for Lua 5.2? @jbsgh thanks for the contribution. Let me think about this a bit before I merge it.

Overall, this looks good, but I'd like to preserve lua 5.2 and luajit support at a minimum. If you can update your PR so that the proper `#ifdef`s are in...

Sorry for being slow on the uptake here... after thinking about this a bit, I'm proposing a function factory interface that more closely mirrors the compression interface: https://github.com/brimworks/lua-zlib/commit/f94aabf944581df865e70b7943962fa18c9d0838 Specifically you...

Are you measuring processing capacity in MB/S before deflation or after? How is the CPU before/after deflation? How does this compare to mod_deflate? https://www.webperformance.com/library/reports/moddeflate/

I believe this line of the file: https://github.com/brimworks/lua-zlib/blob/master/rockspecs/lua-zlib-1.2-1.rockspec#L4 ...needs to be updated as such: url = "git+https://github.com/brimworks/lua-zlib.git" A similar issue was pointed out here: https://github.com/brimworks/lua-ev/pull/30/files You should be able to...

So, I started putting together an example implementation, and in the process I'm refactoring the existing `swift-log` tests so they don't use `LoggingSystem.bootstrapInternal()` since multiple calls to `LoggingSystem.boostrap()` triggers the...

PR has been updated with a proposed implementation. I also refactored the tests so they rely on `bootstrapInternal()` a bit less, although I couldn't completely remove the usage of this...

@FranzBusch I have been thinking over your comment over the course of the last week: > I am still not convinced this is the right thing to do in tests...