Brian Maher
Brian Maher
I like the change, but CMakeLists.txt also needs to be updated for the new location of the tests. Thanks, -Brian
Closing this in favor of https://github.com/nats-io/nats.java/pull/826 ...as that seems to be the path forward. Thanks for moving this along!
This sounds like a neat idea. Do you want to try implementing this in a fork?
The `lz_filter_impl` may be called from Lua with no input parameters in which case we wouldn't want to call `lua_tolstring()` on a non-existent stack element.
Oh, that looks like an oversight on my part. Would you like to open a pull request to fix this? I'm actually not actively using Lua in any of my...
I just merged this in: https://github.com/optiflows/lua-zlib/commit/33f2d8d6269ff84f6cd491dced567e38e0db5b72 can you compare this change with yours? I'm not to familiar with rockspec format. Thanks, -Brian
Unfortunately, I believe the two test failures are related to timezone. If you set your timezone to PST8PDT, I suspect that the test will succeed. If you have ideas on...
What commands are you running to create this problem? I'm on a mac and it works fine for me to run `make macosx`.
Pull requests welcomed :). Sorry, I'm not currently using this software, so if someone else wants to take over ownership, I'm happy to do that too. Thanks! -Brian
Ah, I see this separate PR: https://github.com/brimworks/lua-http-parser/pull/9/files Let me take a quick look.