Nicolas Brichet

Results 256 comments of Nicolas Brichet

https://github.com/jupyter/notebook/pull/7178 has been include to fix https://github.com/jupyter/notebook/issues/7147. But these changes have led to some unexpected behavior, as the table of contents is not initially intended to be hidden by the...

Closing this PR, it is not relevant anymore after the update of https://github.com/jupyter-server/jupyter_server/pull/1518, which has been merged. Thanks again @krassowski for the suggestion.

@jtpio I added you as maintainer in this recipe, if you want to approve it.

I'm a bit puzzled with the behavior of this PR against https://github.com/jupyterlab/jupyterlab/pull/16452. The failing test in this PR is expected because triggering the action `onclick` move the focus to the...

Thinking again about this, the special case is only for Notebook, which expects the focus to stay on the Notebook widget when clicking on the button. Maybe a way to...

@fcollonval @jtpio, any opinion on this implementation ? It may be a breaking change for some extensions that use 'no-focus' behavior. > To be more specific, we could think of...

As said [here](https://github.com/jupyterlab/jupyterlab/issues/15629#issuecomment-2164795154) this is a workaround. A better implementation would be to always get the focus on the widget when clicking on a toolbar button, and find a better...

Thanks for testing it @jtpio. > However it looks like the issue is still here when trying to create a new notebook from the launcher. This seems to be the...

https://github.com/dependabot rebase