Nicolas Brichet

Results 256 comments of Nicolas Brichet

For reference about this change > Unfortunately due to vulnerabilities in third party dependencies we had to strip these attributes to avoid exploitation of user data. The related advisory is...

IIUC the `silent-change` is used to avoid propagating too many signals (in the case pointed by @krassowski when executing a cell). Indeed it make sense to avoid this signal when...

> Thank you [@cos4ni2s](https://github.com/cos4ni2s) for the follow-up information. We were able to reproduced this in triage. We noticed that even after setting the `JUPYTER_CONFIG_DIR` environment variable, the custom path appears...

On a side note, I would rename the title of this PR, I don't think that the `JUPYTER_CONFIG_DIR` is ignored, it's mostly that it creates an unexpected `page_config.json` file.

Awareness of the current Notebook and interaction with the associated kernel would be a really nice feature. FYI I opened https://github.com/jupyterlab/jupyter-chat/issues/128 to track this in `jupyter-chat`.

> * [4.3.0b2](https://github.com/jupyterlab/jupyterlab/releases/tag/v4.3.0b2) bumps jupyter-ydoc to 3.0.0a8 I wonder if this is required, since the `v3` seems to support jupyter-ydocs `v2` https://github.com/jupyterlab/jupyter-collaboration/blob/3.x/projects/jupyter-server-ydoc/pyproject.toml#L32

Thanks @isabela-pf for reporting this. > * The full order of the content isn't clear because of limited visible focus styling. > * [ ] There are unknown focus areas...

Thanks for the review @krassowski and @davidbrochart

@JasonWeill if that's okay with you, I can take care of this PR from now on and try to move forward. In this case, let me know if you have...

> I was under impression that this happens when closing and reopening some PRs. I hadn't noticed it. > The workaround I was using was to merge with `main` branch....