Brice
Brice
`ASTRules` were removed in https://github.com/stacks-network/stacks-core/pull/6482.
In a test to see if the v1 parser can just always be replaced with the v2 parser, 12 blocks failed to validate. Further investigation is required. - Failed processing...
We may want to add some kind of magic comment to allow an unused private function, for example if it is used in tests only (unless there is some better...
I'd be happy with just an error log if the database grows too large. If that's not noticeable enough, we could stall the node at some point, but I'm not...
It turns out this is not as simple as I hoped.
> We sure this fixes the chain sync test? It definitely fixes the one I investigated, https://explorer.hiro.so/txid/0x86ef14fa87fb7de8aef4955290637a7b216d8a47378b7890a87065e41cc8e09c?chain=mainnet
For this release (3.3.0.0.0) we are going to revert back to the old library for secp256k1 (#6645). We will come back to this fix with more time for proper testing.
I think we may still want to switch to the new crate since it is nice that it is all Rust and it removes the need for the separate implementation...
I confirmed that for secp256k1 here, I did use the correct `_prehash` variants, avoiding the double hash situation that we saw in secp256r1.
I'm going to put the `index-range` option back in place and make sure that it works.