Brian Whaley
Brian Whaley
hey @rubiin i have refactored the isCreditCard file, ~~will be submitting~~ just submitted a new PR ~~shortly~~. Thanks for you suggestions!
Thank you @rubiin. @profnandaa when you have an opportunity please do look at the PR. Much appreciated!
apologies, thought this was approved and started cleaning up too soon. PR is reopened and waiting for approval from @profnandaa
@rubiin - i did modify the existing isCreditCard file, and ensured it was backwards compatible. can you evaluate the diff? you will see you can still pass in a credit...
Hi @rubiin and @profnandaa - is there an additional person that can approve this PR? I would like to get it merged to main. Thank you!
@profnandaa and @rubiin , is there an additional person that can approve this PR? I would like to get it merged to main. Thank you!
@WikiRik would you be able to review this PR ? Thank you!
@profnandaa and @rubiin , this PR has been open for almost a month. Is there someone we can add to be the final reviewer? Thank you!
@braaar thanks for the feedback, made the adjustment for that. cc: @profnandaa and @rubiin
hi @profnandaa and @rubiin added PR [#2023](https://github.com/validatorjs/validator.js/pull/2023) to add Belarusian and Romanian Locales