Brian Wernick

Results 48 comments of Brian Wernick

Hmm, interesting... For reference, the link ojw28 points to is now invalid (because of repo changes); the full versioned link is https://github.com/google/ExoPlayer/blob/6a5cd6889258df6b9a08b770e2bf351a5bb30e18/demo/src/main/java/com/google/android/exoplayer/demo/PlayerActivity.java#L193

I'm having a difficult time reproducing the issue in the current `master` branch on KitKat through Nougat. Are there other devices that you have noticed this with?

> You can observe this issue in all devices above 4.3. Even with demo app you will see the same issue. Nope, I have 8 different devices I have tried...

The `VideoView` automatically handles releasing when appropriate (`onDetachedFromWindow()`) and shouldn't require any additional thought towards `onStart`/`onStop` of the parent `Fragment` or `Activity`. The `AudioPlayer` on the other hand should either...

I don't see a reason to worry about the memory being used while in the background (in this case) as Android will inform the app of lowMemory or will tell...

> It’s important to release the player when it’s no longer needed, so as to free up limited resources such as video decoders for use by other applications. This can...

The `VideoView` isn't doing anything that should prevent you from releasing and re-creating it in `onStop` and `onStart`; It just doesn't provide cleaner paths to automatically do it for you.

I'm going to update this to a feature request and look in to adding that functionality. (most likely post `4.1.0` though)

Guys, if have a different question create a new issue instead of trying to hijack the actual one.

I'm glad you brought this up, I'll try to get it in to the 3.0 release