ExoMedia icon indicating copy to clipboard operation
ExoMedia copied to clipboard

Show loading while buffering

Open hadifar opened this issue 9 years ago • 13 comments

In your next release you can consider this it would be nice in low-internet speed connections.

hadifar avatar Feb 11 '16 06:02 hadifar

I'm glad you brought this up, I'll try to get it in to the 3.0 release

brianwernick avatar Feb 11 '16 15:02 brianwernick

@aarongrider, The ExoPlayer doesn't inform us of Buffering updates which is why the OnBufferingUpdateListener is not called, nor is it related because this is a feature request not a bug report

brianwernick avatar Apr 13 '16 23:04 brianwernick

does 3.0 preview have this feature of show buffring while loading i want to test it ?

kashifandroiddev avatar May 07 '16 09:05 kashifandroiddev

@kashifandroiddev no, this hasn't been added yet (otherwise the request would have been closed)

brianwernick avatar May 07 '16 14:05 brianwernick

You can add new ExoPlayerListener to your Videoview and in onStateChanged it fires "Exoplayer.STATE_BUFFERING" as playbackstate when it's buffering. I tested with exomedia 2.5.6 and it works.

appyo avatar Jun 22 '16 22:06 appyo

@appyo While you can register that listener it doesn't provide quite the functionality this addresses. The STATE_BUFFERING represents a fairly short cache of the video, on slow internet connections this may only be a second or so, which will play then hit the buffering again. Ideally we would monitor the network speed and determine a minimum amount (or allow it to be specified) that we need buffered before we automatically resume playback.

What you mentioned is already used (in 3.0) to represent loading when seeking and initial load

brianwernick avatar Jun 22 '16 22:06 brianwernick

Thanks @brianwernick for your information. I did not know that and i use this only for showing progressbar or similar to inform the user that the video freezes briefly and he does not think that the player has crashed or so. You are right of course it is better if you could adjust the buffering to the network speed. I will test the 3.0 soon, many thanks for your great work.

appyo avatar Jun 22 '16 23:06 appyo

this feature is a great. I had implemented this in 2.5.6 by adding an exoplayerlistener which is not available in version 3.0.0

miladz68 avatar Jun 25 '16 14:06 miladz68

how can i know that video is buffering in version 3.0.1.Can you add a callback when video starts and ends buffering .

vishnuganta22 avatar Aug 18 '16 06:08 vishnuganta22

hey @brianwernick

Thanks for the great library.

The issue is still opened for 2 years. Should we wait for the issue to be fixed or try different options?

Do let me know as we are moving into production. Thanks

IOException722 avatar Jun 22 '18 06:06 IOException722

I'm still planning on adding the functionality; it's actually one of the main tasks for the 5.0 release. However I don't know how soon I'll be able to get to it (I'm hoping in the next month)

brianwernick avatar Jun 22 '18 14:06 brianwernick

Have you added that feature?

deebash avatar Jun 17 '19 02:06 deebash

There are two parts to this request:

  1. Improving the existing functionality to show loading while buffering when playback catches up to the buffer.
  2. Adding the capabilities to track the buffer / download speed and dynamically adjust the playback resumption.

With the work that we have already done in 5.0 to improve state communication has addressed part 1 above. Because part 1 seems to be the more important part of the request for most I'm going to move part 2 to a future release so that we can get the 5.0 release out sooner

brianwernick avatar Sep 22 '22 15:09 brianwernick