brianreen comments

Results 5 comments of


                                            brianreen

Fix the source of the dt=0 error when using adaptive time step

Yes, I will help review this PR.

Fix the source of the dt=0 error when using adaptive time step

@JeroBnd Does this issue only occur when interval_seconds is set incorrectly? Since I did not think #154 changed code that sets dtInterval, could you clarify what lines of code you...

Fix the source of the dt=0 error when using adaptive time step

@JeroBnd @weiwangncar The proposed change appears to make the following changes from the standard version of the code: A) If between one and two (preliminary) timesteps from the target time...

Fix the source of the dt=0 error when using adaptive time step

@JeroBnd @weiwangncar It does not seem to me that these are sources of numeric error. Lines 166-172 enforce the precision but only for max_increase_factor. In the case where the tentative...

Fix the source of the dt=0 error when using adaptive time step

@dudhia No, I do not think this modification is safe. It appears that the code in this pull request will result in the adaptive timestep not functioning correctly in cases...