Brian McGee

Results 171 comments of Brian McGee

P.S. Thanks for taking the time to flesh this out, and sorry for taking a while to get around to reviewing this.

There isn't really a uniform approach for `--check` across formatters, so the current `--ci` approach is just to run the formatters and see if anything has changed. I'd like to...

I'll dig into this a bit more over the holidays. @zimbatm @jfly I'd like your take as well. A simple pass-through is possible if `-check` is well supported. Where it...

I can see the value in this. A previous dry run suggestion wanted us to run the formatters in some temp copy of the whole source tree which I thought...

Having a fallback global config file implies a default global set of formatters that must be available in your `PATH`. Since I typically use `treefmt` within `nix` devshells, this approach...

In this instance, `--no-cache` is the simplest way of guaranteeing that multiple instances of `treefmt` running at the same time do not conflict. However, on larger repos, the loss of...

I don't know if parallel execution is a path we should go down 🤔

Thanks for the PR! I'm wondering if it might be better to allow passing through git args? :thinking: It would make it more general, and possibly help users to further...

I don't see us moving back to a git alternative; there is too much risk of feature drift/bugs like we experienced already.

> More concretely, what's your idea? Is it having the ability to pass arbitrary args to git ls-files? Yeah. Straight pass through I guess.