treefmt icon indicating copy to clipboard operation
treefmt copied to clipboard

Add a Stdin Specification

Open jfly opened this issue 7 months ago • 9 comments

This completes step 1 of https://github.com/numtide/treefmt/issues/573#issuecomment-2877869301.

jfly avatar May 13 '25 22:05 jfly

@brianmcgee @zimbatm, is there anything I can do to help move this forward?

jfly avatar Jun 24 '25 17:06 jfly

It's unclear to me if this documents the current behaviour or the desired behaviour. If it's the desired behaviour, isn't there some work needing to be done in treefmt to support that before we publish a spec?

brianmcgee avatar Jun 27 '25 11:06 brianmcgee

If it's the desired behaviour, isn't there some work needing to be done in treefmt to support that before we publish a spec?

Yes, treefmt needs changes to support this. I'm happy to implement that (in this PR or a separate one). I just don't want to put in the effort until I know we like this approach.

jfly avatar Jun 28 '25 15:06 jfly

I'll try to put my brain on this in the next few days. Been a busy few weeks :tired_face:

brianmcgee avatar Jul 07 '25 08:07 brianmcgee

@brianmcgee, friendly ping

jfly avatar Jul 21 '25 03:07 jfly

P.S. Thanks for taking the time to flesh this out, and sorry for taking a while to get around to reviewing this.

brianmcgee avatar Jul 21 '25 18:07 brianmcgee

@brianmcgee @zimbatm, I could use another review on this. If we're happy with the state of this, then I'd like to work on the underlying implementation.

jfly avatar Jul 22 '25 23:07 jfly

Any remaining work to be done here, or is this just waiting for review?

I'd be happy to lend a hand, if there's any way I can help.

cstrahan avatar Oct 27 '25 16:10 cstrahan

@cstrahan I think this is ready for implementation. I'm pretty swamped right now. If you're up for putting together an implementation, I'd be happy to code review!

jfly avatar Oct 27 '25 16:10 jfly