Brian Lai

/test connector=connectors/source-pipedrive > :clock2: connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/3065383219 > :white_check_mark: connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/3065383219 Python tests coverage: ``` Name Stmts Miss Cover -------------------------------------------------- source_pipedrive/__init__.py 2 0 100% source_pipedrive/source.py 36 2 94% source_pipedrive/streams.py 77 8...

/test connector=connectors/source-pinterest-ads > :clock2: connectors/source-pinterest-ads https://github.com/airbytehq/airbyte/actions/runs/3065384264 > :x: connectors/source-pinterest-ads https://github.com/airbytehq/airbyte/actions/runs/3065384264 > :bug: > ### Build Failed Test summary info: ``` Could not find result summary ```

/test connector=connectors/source-pinterest > :clock2: connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/3065411272 > :white_check_mark: connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/3065411272 Python tests coverage: ``` Name Stmts Miss Cover -------------------------------------------------- source_pinterest/utils.py 4 0 100% source_pinterest/__init__.py 2 0 100% source_pinterest/source.py 183 12...

ran a few local `connectors-ci` runs of hubspot, a few low-code connectors to see that tests passed before the merge

> I also had the following question: should we remove the dependency to requests from the interfaces? Right now, HttpRequestSender. send_request returns objects that are specific to the requests library...

Given how we're repurposing the `DatetimeStreamSlicer` and renaming it to go under `DeclarativeStream.incremental_sync` field, I think it still feels best suited to live there instead of directly on the Stream....

@erohmensing gonna close this one out since this should mostly be covered by the changes when I merged https://github.com/airbytehq/airbyte/pull/37429 . Feel free to reopen if you think we still need...

Live tests ✅ against a connection: https://github.com/airbytehq/airbyte/actions/runs/9024913362/job/24799667426 Also tested in my own personal workspace for the streams mentioned

@grubberr Yes that is correct. I tried to account for this using a temporary workaround here: https://github.com/airbytehq/airbyte/pull/22294/files#r1093992449 This was a case I noticed during the migration. In the case where...

@grubberr Yes, I believe both should work with this approach. Both of your new connectors have custom slicer implementations that inherit `CartesianProductStreamSlicer` and both have a child DatetimeStreamSlicer which should...