airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Synchronous python CDK: make sync mode agnostic

Open erohmensing opened this issue 10 months ago • 2 comments

Always checkpoint state after the slice. Definitely cleanup needed

don't emit sentinel state in full refresh mode

add note when checking that we can't remove the sentinel for the no slices case

don't put checkpoint intervals under incremental only

erohmensing avatar Apr 11 '24 17:04 erohmensing

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 1:32am

vercel[bot] avatar Apr 11 '24 17:04 vercel[bot]

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

  • #36999 Graphite 👈
  • #37022 Graphite: 1 other dependent PR (#37023 Graphite)
  • #37021 Graphite
  • #37488 Graphite: 3 other dependent PRs (#37489 Graphite, #37514 Graphite, #37626 Graphite)
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @erohmensing and the rest of your teammates on Graphite Graphite

erohmensing avatar Apr 11 '24 17:04 erohmensing

@erohmensing gonna close this one out since this should mostly be covered by the changes when I merged https://github.com/airbytehq/airbyte/pull/37429 . Feel free to reopen if you think we still need to address this

brianjlai avatar May 06 '24 22:05 brianjlai