Brian Duff

Results 6 comments of Brian Duff

I think they might be validating `gr_key` and `gr_token` remotely - these represent the re-captcha token that's supposed to prevent bots using apis. I'm also running into this issue (with...

Thanks for the feedback so far. I'll take a look at the failing checks next.

I think this is ready to be reviewed. Thanks!

> Thanks for addressing the comments, this looks pretty good! > > How does the added asynchronicity interact with the BES? I recently sent a change that delayed the closure...

OK, I was able to get a message to print! I had to add a new lifecycle method to BlazeModule to facilitate this, but I think the experience is far...

> Looks good to me, thanks! It's likely that Bazel team members will only be able to review this for approval in the new year though. Understood. Thanks for the...