Brian Donahue

Results 36 comments of Brian Donahue

I'm seeing this same issue and I just installed the pik gem today. Is this fixed in a release, and if so, how can I install the fix? Thanks!

This does seem to be a deprecation warning and not an actual error that will break the integration, so for now it's not a huge emergency, but when they remove...

For anyone looking for a possible workaround for this - it may not be workable in your application, but since I was able to require authentication for my entire SPA,...

@Yoda-Soda @somyarocketium I submitted #254 but thought I'd tag you in case you wanted to check it out and/or provide feedback. Seems like a viable approach if we want to...

@isabelle-dr @bdferris-v2 It seems that `@Required` annotation is used to validate both that the header exists ([`DefaultTableHeaderValidator.java`](https://github.com/MobilityData/gtfs-validator/blob/master/core/src/main/java/org/mobilitydata/gtfsvalidator/validator/DefaultTableHeaderValidator.java#L66)) and that the field is non-empty ([`RowParser.java`](https://github.com/MobilityData/gtfs-validator/blob/master/core/src/main/java/org/mobilitydata/gtfsvalidator/parsing/RowParser.java#L130)). If I understand correctly, the goal...

> Could we use the `MissingRequiredColumn` notice for this? @isabelle-dr I believe so. I'll just add a validator that manually checks that the header exists, and throws that notice, and...

@isabelle-dr on further review - I see that there is a `GtfsTableContainer.TableStatus.INVALID_HEADERS` status for Tables that is supposed to represent if columns are missing, which is tested [here](https://github.com/MobilityData/gtfs-validator/blob/master/core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java#L129). I think...

> I think we also use `@Required` for files. You're correct, I missed that detail. Well, we could still do this and just add a `@RequiredHeader` annotation and leave the...

@isabelle-dr Hello! I am taking a look at this. It seems like the most comprehensive solution would be: 1. generate a **warning** if there is a single agency in `agency.txt`...

@bdferris-v2 OK, I was looking at this comment (don't think I have access to see the original repo page) > I think that @e-lo refers to [this part](https://github.com/MobilityData/GTFS_Schedule_Best-Practices/blob/master/en/routes.md) of the...