Brian Armstrong

Results 106 comments of Brian Armstrong

Hi! Sorry to hear you're feeling frustrated. I've wanted to create examples but I haven't got around to it yet. There is something like an example in the tests here...

Hi @Hiffi Can you provide a larger code sample/more context? I'm fairly certain the tests test this exact case, and it seems to suggest otherwise https://github.com/quiet/libcorrect/blob/master/tests/rs_tester.c#L99

See also https://github.com/quiet/libcorrect/blob/master/src/reed-solomon/decode.c#L336

Thanks, I hope it works well for you. The one thing I can think of here is that it won't copy the received message when there are too many errors....

Unfortunately I still don't have quite enough code here to see what's going on. Can you come up with a short example that demonstrates this behavior and then provide me...

This is a pretty fascinating bug report, but ultimately I've decided this is actually the correct behavior. The first oddity to notice here is that a message that's all 0s...

Hi @meerd In general, Reed-Solomon doesn't make any guarantees about what happens once you exceed the error-correction capabilities. There simply isn't enough information present to know whether this has happened....

You caught my attention with the description of this bug ;) I tried to mimic libfec's behavior on this particular issue as I wanted to make sure the shim would...

It's not going to work with how things are currently implemented no, you would have the elide the flush. I wouldn't say it's incompatible though, there would just need to...

@racerxdl Sorry I haven't had much time to review this. Looks like you're making good progress. One thing I'd be curious to see is if we could generate VS stuff...