Brian M. Adams

Results 18 comments of Brian M. Adams

Where's the right place in the code base to put a convenience function for converting sets of scalars to a string as I am doing in EnvironmentOptions for default management?...

Should I leave SequenceStatisticalOptions in place or remove it? Or at least remove its use in other Options classes? I see it's deprecated and it's complicating MetropolisHastingsSGOptions among other Options...

Related, should other deprecated Options classes like MetropolisHastingsSGOptions be left in place or removed for this refactor?

To close out this issue, need to take one more cleanup pass and review: - That default member values are only used in set_defaults. Also review for cases where registerOption...

In the course of doing this, I noticed that (I think) the GPMSA test and examples are scaling simulation and experiment data by variance instead standard deviation. If that's the...

For now, I'm working around this with: ``` diff --git a/queso/src/core/src/Environment.C b/queso/src/core/src/Environment.C index 500ed27..a4e24ff 100644 --- a/queso/src/core/src/Environment.C +++ b/queso/src/core/src/Environment.C @@ -1735,10 +1735,10 @@ void queso_terminate_handler() // The system terminate_handler may...

Correction, that doesn't fix it. It seems whatever terminate_handler GDB registers is not NULL and is causing the recursion, so the workaround is to just not register queso_terminate_handler. I'll try...

The conditional logic for this warning https://github.com/libqueso/queso/blob/469911ac41a8a829b994ac296e341386589a0721/src/stats/src/TransformedScaledCovMatrixTKGroup.C#L330-L343 is comparing units of variance (covariance diagonal) to domain bounds. Should probably instead by comparing sqrt(var) to the bounds.