queso icon indicating copy to clipboard operation
queso copied to clipboard

Double-check units on the "covariance is too big" warning

Open dmcdougall opened this issue 7 years ago • 1 comments

dmcdougall avatar Feb 21 '18 17:02 dmcdougall

The conditional logic for this warning https://github.com/libqueso/queso/blob/469911ac41a8a829b994ac296e341386589a0721/src/stats/src/TransformedScaledCovMatrixTKGroup.C#L330-L343 is comparing units of variance (covariance diagonal) to domain bounds. Should probably instead by comparing sqrt(var) to the bounds.

briadam avatar Feb 23 '18 17:02 briadam