Brett Willis

Results 40 comments of Brett Willis

@lahirumaramba any thoughts on this?

@lahirumaramba @prameshj I completed the test suite adding integration tests and unit tests. All relevant tests that were applied to `setCustomUserClaims()` are applied to the relevant claims functionality in `updateUser()`....

@lahirumaramba @prameshj I noticed you added the "help wanted" label. I'm more than happy to submit a PR for this, however we need to align on the proposal first. What...

@lahirumaramba @prameshj didn't get a response so assuming that you were ok with my original proposal? I have drafted the PR accordingly, along with tests etc, it would be great...

@danimoh this line prevents us from showing the video inside the shadow DOM. Can't use it in UI frameworks that utilise shadow DOM (web components) e.g. LitElement. https://github.com/nimiq/qr-scanner/blob/34bccc6b278672e28d6eb62f07c1832f1e6d2e92/src/qr-scanner.ts#L185 Edit: this...

Agree. Depending where we deploy, we may want to use the native queue infrastructure like Amazon SQS, or Google Cloud Tasks, etc. The same goes for the clock worker, where...

@lahirumaramba @prameshj please check thanks 🙏🏼

Also, why are issues disabled on this repo?

@Tomaszal here are some of my comments/inputs: - It would be most flexible to allow `Promise`'s/async functions for generating the value incase there needs to be some async operation involved...