brettlounsbury
brettlounsbury
https://issues.apache.org/jira/browse/IO-649
I took a look at the coverage drop. I forgot to add tests that exercise the bounds checking of the bufferSize inputs to both contentEquals method. I've pushed a new...
@garydgregory - can you take a look or propose another reviewer?
Hi @garydgregory, I don't see any comments from you other than the request for a benchmark. I have updated IOUtils to include a test dependency on JMH and and to...
@garydgregory, I really appreciate your thorough review of my code. I think at this point I have addressed your comments, but if you have any others please let me know....
@garydgregory - Any other feedback here or anything else I can do to improve this?
@garydgregory - Can you take another look or suggest another reviewer?
> Sorry about the delay, last day of vacation here ;-) No worries - hope you had a great vacation!
@garydgregory - can you take another look when you have a chance.
@garydgregory - I think all necessary changes have been made. Are you able to take a look?