Brett Hoerner
Brett Hoerner
The idea makes sense to me, PRs welcome.
If you `-o yaml` the `sentry-kubernetes` what is the output?
Hmm, I guess neither of those list permissions? I was hoping to verify the `--verb=get,list,watch --resource=events` part of the role worked.
Thanks! @Chnkr Can you diff with yours?
Awesome, does anyone know what (if any) adjustments need to be made to the original commands @vdboor posted? ``` kubectl create sa sentry-kubernetes kubectl create clusterrole sentry-kubernetes --verb=get,list,watch --resource=events kubectl...
Interesting. I don't maintain any of my own global state, so it must be something inside of the `kubernetes` or `raven-python` clients, hmmm...
I think you just need to call `handleByAnnotation();` on your JsonCodec first: https://github.com/capnproto/capnproto/blob/ee3aac938e86238f67924396dad4b91a41d419ac/c%2B%2B/src/capnp/compat/json.h#L209-L217
> I think we can leave the fetch() implementation as is, since you could easily just set the extension header yourself: Naive question, but I figure most people will forget...
> Thought of another annoying case, what if the eyeball requests a normal websocket without compression, and their worker is proxying the websocket connection? Then the eyeball worker is uncompressed,...
> What's not clear to me is how it's a breaking change - an error is an error and we have never bothered with error message stability as a back...