cyvcf2 icon indicating copy to clipboard operation
cyvcf2 copied to clipboard

NumPy version compatibility

Open tomwhite opened this issue 1 year ago • 2 comments

It's not clear what version of NumPy each cyvcf2 release was built against, which can cause issues with binary compatibility. For example, when running cyvcf2 0.30.16 with NumPy 1.22.4 I get

RuntimeError: module compiled against API version 0x10 but this version of numpy is 0xf

(Ideally I would just upgrade to NumPy 1.23, but I can't since Numba (which I am also using) doesn't support it yet.)

tomwhite avatar Aug 09 '22 13:08 tomwhite

Sounds like the wheel-building process should ensure that https://pypi.org/project/oldest-supported-numpy/ is installed. Usually this just goes in the pyproject.toml file as a build requirement, but it might be necessary to modernise the build system.

grahamgower avatar Aug 09 '22 13:08 grahamgower

@grahamgower That seems to be exactly what we need - thanks!

tomwhite avatar Aug 09 '22 14:08 tomwhite

@brentp could you tag a release sometime so we can test this? Thanks!

tomwhite avatar Sep 28 '22 11:09 tomwhite

done. thanks for the reminder

brentp avatar Sep 28 '22 14:09 brentp

Thanks @brentp!

tomwhite avatar Sep 28 '22 14:09 tomwhite