Brent Roose

Results 287 comments of Brent Roose

> I'm not encrypting anything here, do you think we should offer encrypting the password to be transparent for the devs? Definitely, passwords should always be encrypted and devs shouldn't...

> To clarify, passwords should be hashed + salted, not just encrypted. 🙂 > > This is probably worth a separate PR for that functionality. True, sorry for the confusion!...

Gonna merge this in a feature branch, and finetune it on there 👍 Thanks for the help, and sorry it took so long to get merged

Since we're not going for sub-minute scheduling, I don't think we should add this PR for now. Maybe when we're further working on Auth we can reconsider it, but I'm...

I think I like where this is going. What's still missing is the public facing API. How would framework users interact with this auth layer? Did you have some thoughts...

```php final readonly class AuthController { public function __construct( private Authenticator $authenticator, ) { } public function login(Request $request): Response { $user = ... // get the user with the...

@WendellAdriel Yes go for it! 👍

Definitely `league/commonmark` 👍

This will actually need some more refactoring. Right now a view renders itself — not ideal. We could move that rendering logic to somewhere else. At the moment, it's the...

@WendellAdriel I need to dive into it again, but it'll probably be another week. I wanna finish some of the last things for tempest/console first, and then shift my focus...