Brendon Boshell

Results 6 comments of Brendon Boshell

I want the keep the ability to download binary files, but I know it could be problematic downloading large binary data. What behaviour do you expect here? Maybe a max...

Yes, I would accept a pull request for this provided the change was backwards compatible. Adding a `response` property to the [`ctx object`](https://github.com/brendonboshell/supercrawler/blob/master/lib/Crawler.js#L320) seems the most obvious route?

If I understand correctly, this is by design. The process will wait until further URLs are available for crawling. There could be no URLs in the queue for three reasons:...

On second thoughts, if you have not called `start()`, it should exit. This is probably because [we do not disconnect from redis](https://github.com/luin/ioredis/issues/335). I will take a look at this.

In the meantime, you can configure Terser to turn off the `collapse_vars` option. The webpack config will look something like this: ``` optimization: { minimizer: [ new TerserPlugin({ terserOptions: {...

I have tried with the above snippet and experience the same issue.