Brendan Long

Results 40 comments of Brendan Long

We wrote a mock for the email-sending function that saves the token in a variable instead of sending the email, and then the tests can just read it. https://facebook.github.io/jest/docs/en/mock-functions.html

Removing this entirely might be complicated if you want to maintain backwards compatibility, but two easy fixes for the performance issue would be to replace the hard-coded difficulty of 10...

There's still a lot to do: - [x] Implement `call` - [ ] Handle Dblib exceptions correctly - [ ] Ensure we don't use the same connection on multiple threads...

Hmm I'm having trouble getting the driver to load. If I do it the same way as the other drivers I get errors like: > Failed to load driver for...

With debugging: ``` (cd _build/default/tests && ./test_sql_lwt.exe) [DEBUG] Caqti_dynload: recorded_predicates = native [DEBUG] Caqti_dynload: recorded_packages.core = bigarray caqti ptime re re.posix result sexplib sexplib.0 stringext unix uri [DEBUG] Caqti_dynload: recorded_packages.load...

Ok, I'll open a pull request with freetds. Thanks for helping me find out where the problem was! @paurkedal Sorry about the semi-messy code right now. ocp-indent is doing weird...

Yeah my remaining concern is that we still need to serialize usage if we're not using the same thread every time. For example, if someone runs this: ``` Deferred.both (Db.exec...

I wonder if there's a way to make the API handle that case properly without being too complicated. It seems really bad that a straightforward use of the Async API...

I got the changes I needed into `ocaml-freetds` but now I'm not quite sure how to approach the parameters, since I'm pretty sure FreeTDS doesn't support them. I can relatively...

I tried to review this but I can't get the updated schema to work. Selecting a different theme doesn't do anything, and I get this output on the console: ```...