Brecht Machiels

Results 214 comments of Brecht Machiels

If possible, try running tox as with Travis CI to avoid duplication. But it's probably a good idea to get things running first without that complication.

I'm afraid your suggestion won't work for text that is eventually wrapped in multiple tags. The ampersand, for example, will be escaped multiple times, so you end up with "&"....

With b7f142edc3721fbf185b9d3e8c4e652a090a5f30, the BibTeX parser is much more capable. It now handles accented characters properly and parses names as BibTeX does.

I'm seeing a similar error (Python segfault + "node down: Not properly terminated"). It seems to fail consistently in my [Ubuntu CI runs](https://github.com/brechtm/rinohtype/runs/6940264603?check_suite_focus=true) (these logs will be unavailable soon) and...

@willmcgugan I've completed the missing things on the checklist, so this one is ready for review.

The CAPTCHA has not yet returned, but the script fails to claim the book with `IndexError('list index out of range',)`.

My issue is that this is confusing behavior. How should the user know that they shouldn't use the _.rst_ extension when `.. include::`ing a file? Why do they even need...

The PR works when building a project, but there's obviously still something missing. I'll need to look into the failing tests...

I have some questions on how to continue with this: 1. Should this target _master_ or _0.5_? 2. mypy: `sphinx/environment/adapters/toctree.py:142:51: error: "Domain" has no attribute "labels"; maybe "label"? [attr-defined]` _Domain_...

Is there anything I can do at this point? Thanks!