Brandon Roberts

Results 59 comments of Brandon Roberts

`--no_cuda` has an error with the NER task, because the `device` can still be set to GPU here: ``` class Ner(BertForTokenClassification): def forward(self, input_ids, token_type_ids=None, attention_mask=None, labels=None, valid_ids=None, attention_mask_label=None): #...

What are some general areas in the codebase that could use these changes the most? This could be a great opportunity to improve the code and also to add unit...

I'm going to give it a go on some of these. Thanks for compiling this list, I think it will be useful for myself and others. I'm curious if we...

`We already had some aggressive refactors done and now it's harder to import historical patches (e.g. I was restarting work on 3dfx this week and it's very hard because of...

Tracking work here: https://github.com/brandonrobertz/dosbox-staging/tree/strings-modernization

> `>>>const return a always copied object as const makes no sense Thanks! I was going to ask for a code review for things like this. Particularly in performance. Old...

> As i said i have non-standard installation so if someone has energy to check against bog-standard DOSBox Staging install to confirm it actually doesn't work then thank you. I've...

Debugger is broken and has been for quite some time. I've heard that it works in some very narrow environments, but the debugger certainly needs some love. If you got...

> And scratch that again: after resuming execution the main window does not update anymore. Yes, this is the "broken" behavior that I've always seen. Sometimes I can get the...

Love this concept. 💚 Right now lots of the userland is implemented via C++ code in `shell/`. I started going down the road of building test cases for our C++...