Brandon Correa

Results 6 comments of Brandon Correa

This looks like an issue with [fresh.core line 42](https://github.com/slagyr/fresh/blob/bd1ced66705f1bdbfc2e476e0454dbbbfd859f49/src/fresh/core.clj#L42), `ns-to-file`, which is returning URL Encoded file paths. ````clojure (file (.getFile url)) ```` One solution would be adding a URLDecoder. This...

I noticed the loose integer behavior when working on this. I'm no expert in Dart, so it's very possible there are holes in some of these functions. My approach with...

You're right! Looking at the [ClojureScript math ns](https://github.com/clojure/clojurescript/blob/105d3febb8cb5e72c1dd27f396f3f363a73e7879/src/main/cljs/cljs/math.cljs#L521), they use `js/Number.MIN_SAFE_INTEGER` and `js/Number.MAX_SAFE_INTEGER`. I see Dart has `js_interop` and `js_interop_unsafe`. You think it's worth utilizing these to get that `Number`...

@weavejester The PR has been updated to include all your recommendations, except for those regarding `test_runner.cljr` and commit history. How would you like these addressed? Should commits just be squashed...

> I'm assuming after this PR is merged, all future additions will need to consider CLR compatibility? The state of Clojure survey reports that about 1% of respondents use it...

@tomdl89 Unofficial support of Clojure CLR may also be worth considering. This way, future contributors need not concern themselves with CLR. If there happens to be a release that doesn't...