Brandon Smith

Results 16 comments of Brandon Smith

Could this be inferred by the bin?

I'm not opposed to the `optional` modifier, but does it provide material benefits over `assert.any`: ```js const values = [undefined, '🦄'] for (const value of values) { assert.any([is.undefined, is.string], value)...

I support the sibling approach as you've outlined: exporting both the individual named exports and a comprehensive default object give consumers flexibility. This will allow for both of the following:...

It may be _possible_ but I'm not sure you'd want to. VirtualBox needs several drivers to work correctly, add unless they're already installed I imagine elevated privileges or UAC prompts...

> > Will scale down the device ratio until the image fits > > I don't see how that will work in practice. Most websites are long enough to make...

> Could we have a temporary flag that changed `--full-height` to mean as much as possible by scaling while still keeping the set width/height options? To make sure I understand:...

Unfortunately, the underlying chromium limitation is still outstanding and is not addressed by the puppeteer release.

Apologies for the thread-bump but confirming this behavior on all sites. As well, across both Linux and Windows. I hope to investigate the root cause soon. ![image](https://user-images.githubusercontent.com/4730164/97826590-fdddba80-1c8f-11eb-9d58-79f1a70bc8b8.png)

Appears to be a Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1043959&q=screenshot%20fullPage&can=2. The only reliable workaround I've seen is to take a bunch of partial screenshots as you scroll and then stitch them back together.

@brockpetrie @BrockReece - Is there interest in adding this support? I'm currently using a local fork but would love to use `vue-moment`!