Jon Brandvein

To be clear, it seems like "treated the same way" means that the character put into the string literal is LF, regardless of whether the `NEWLINE` token was generated by...

I think the formatting swallowed your console output in the escaped case. But what I'm understanding is that the correct behavior is that `CR` is treated the same as `LF`...

Ok, I get it now -- third time's the charm. I think we can generalize this issue to expanding the TODO in the spec for defining the tokenization of newlines....

Thanks for spotting this ambiguity. I can't repro in Python 3.11.9 because it complains that slices aren't hashable, but inspecting the tree obtained from `ast.parse('a[1,2:3]')` confirms it's a tuple who...

This sounds like a reasonable change. I'm glad the blocker was removed. We'd need a flag in Bazel and probably in the Go implementation.

Adding some context: We don't allow trailing commas for unparenthesized tuple expressions like ```starlark x = 5, ``` because it doesn't really save much typing compared to the more explicit...

> Looks like there's a lib/BUILD file with a bzl_library for unittest.bzl that also needs to be removed. Ignore, that was before I saw the file wasn't in fact deleted...

I agree with the spirit of this change, i.e. having strings canonicalized into label objects at the point where they're passed to `select()`. This could simplify some logic and be...

`cleandoc()` seems like nice behavior. I remember `dedent()` being not too useful, because it didn't handle strings with text on the same line as the opening triple quote. (Java textblocks...

My main concern is whether there are subtle differences possible in a naive implementation e.g. w.r.t. rounding behavior, and how much effort we have to go through to ensure compatibility...